Troepje commented on PR #494: URL: https://github.com/apache/celix/pull/494#issuecomment-1464876478
Thanks for the quick and in depth replies! In my first attempt I found that I did a complete rewrite without understanding why/how it worked and what the principle is behind the mentioned init function. The strategy in this fix is making it similar to the tcp admin. Im very willing to help improve the design, but lets do that in another Issue/PR. @PengZheng Ill make the update with the timeout as you suggested! Should I also update the property name? Now its similar to tcp admin, but your suggestion will make it more clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
