pnoltes commented on code in PR #476:
URL: https://github.com/apache/celix/pull/476#discussion_r1153273570
##########
libs/framework/src/bundle.c:
##########
@@ -376,20 +355,8 @@ celix_status_t bundle_isSystemBundle(const_bundle_pt
bundle, bool *systemBundle)
}
celix_status_t bundle_close(const_bundle_pt bundle) {
- bundle_archive_pt archive = NULL;
-
- celix_status_t status;
-
- bundle_closeModules(bundle);
- bundle_closeRevisions(bundle);
- status = bundle_getArchive(bundle, &archive);
- if (status == CELIX_SUCCESS) {
- bundleArchive_close(archive);
- }
-
- framework_logIfError(bundle->framework->logger, status, NULL, "Failed
to close bundle");
-
- return status;
+ fw_log(bundle->framework->logger, CELIX_LOG_LEVEL_DEBUG, "Usage of
bundle_close is deprecated. Called for bundle %s", bundle->symbolicName);
Review Comment:
there is no xyz instead. bundle_close was never needed, but I will update
the log with a statement that the call is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]