PengZheng commented on code in PR #569:
URL: https://github.com/apache/celix/pull/569#discussion_r1231669957
##########
libs/framework/src/framework.c:
##########
@@ -1543,6 +1568,9 @@ bool celix_framework_useBundle(framework_t *fw, bool
onlyActive, long bundleId,
bundleId);
if (entry != NULL) {
+ if (onlyActive) {
Review Comment:
Listing installed bundles and keeping starting/stopping a specific bundle
should not interrupt each other. If we insist bundle state does not change
during bundle use callback, then they do contend for the per-bundle lock.
Similarly, using a installed bundle's resource file generally has nothing to do
with the bundle being active. In such cases, `celix_framework_useBundles` is
more suitable than `celix_framework_useActiveBundles`.
Another reason is the deadlock in pubsub_topology_manager, which I detailed
in the summary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
