pnoltes commented on code in PR #582:
URL: https://github.com/apache/celix/pull/582#discussion_r1246354525
##########
libs/framework/src/celix_framework_utils.c:
##########
@@ -196,7 +197,23 @@ static celix_status_t
celix_framework_utils_extractBundlePath(celix_framework_t
//other errors should be caught by
celix_framework_utils_isBundleUrlValid
return CELIX_ENOMEM;
}
- celix_status_t status = celix_utils_extractZipFile(resolvedPath,
extractPath, &err);
+ celix_status_t status = CELIX_SUCCESS;
+ if (celix_utils_directoryExists(resolvedPath)) {
Review Comment:
Nice :) and a shockingly small change to support uncompressed dir (although
I know much has happened in other PR to prepare this (e.g. handling of
symlinks)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
