PengZheng commented on code in PR #589:
URL: https://github.com/apache/celix/pull/589#discussion_r1271644444
##########
libs/pushstreams/CMakeLists.txt:
##########
@@ -16,10 +16,11 @@
# under the License.
set(PUSHSTREAMS_DEFAULT_ON ${CELIX_CXX17})
-celix_subproject(PUSHSTREAMS "Option to build the PushStreams library"
${PUSHSTREAMS_DEFAULT_ON} DEPS PROMISES)
+celix_subproject(PUSHSTREAMS "Option to build the PushStreams library"
${PUSHSTREAMS_DEFAULT_ON})
Review Comment:
Yes. Previously `celix_subproject` will only hint our users to enable
missing components without automatic configuration.
For a long chain of dependencies, users have to try several times to work
out a working configuration for Celix.
Imagine that we have several Conan packages, each of them has intra-package
dependencies like Celix, and they also have inter-package dependencies. Then
working out a working configuration for a downstream user can be daunting.
With this in place, our users only specify what they need directly, then
everything else is automatically configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
