PengZheng commented on code in PR #470:
URL: https://github.com/apache/celix/pull/470#discussion_r1390191593
##########
libs/utils/src/version.c:
##########
@@ -95,15 +98,18 @@ celix_status_t version_isCompatible(version_pt user,
version_pt provider, bool*
return CELIX_SUCCESS;
}
-celix_version_t* celix_version_createVersion(int major, int minor, int micro,
const char* qualifier) {
+celix_version_t* celix_version_create(int major, int minor, int micro, const
char* qualifier) {
if (major < 0 || minor < 0 || micro < 0) {
+ celix_err_push("Invalid version number. Major, minor and micro must be
>= 0");
Review Comment:
Usage of ERR should be documented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
