PengZheng commented on code in PR #802:
URL: https://github.com/apache/celix/pull/802#discussion_r2416042663
##########
libs/framework/src/service_tracker.c:
##########
@@ -566,16 +559,22 @@ static void
serviceTracker_untrackTracked(service_tracker_t *tracker, celix_trac
}
}
+ bool ungetSuccess = true;
+ bundleContext_ungetService(tracker->context, tracked->reference,
&ungetSuccess);
Review Comment:
Note that service instances obtained from a factory will be destroyed, thus
we must notify service users (i.e., calling various tracking callbacks) before
`bundleContext_ungetService`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]