pnoltes commented on code in PR #839: URL: https://github.com/apache/celix/pull/839#discussion_r3047166111
########## bundles/remote_services/topology_manager/src/topology_manager.c: ########## @@ -47,14 +48,17 @@ #include "service_reference.h" #include "service_registration.h" #include "celix_log_helper.h" -#include "topology_manager.h" #include "scope.h" #include "hash_map.h" #include "celix_array_list.h" +#include "celix_string_hash_map.h" +#include "celix_convert_utils.h" //The prefix of the config property which is used to store the interfaces of a port. e.g. CELIX_RSA_INTERFACES_OF_PORT_8080. The value is a comma-separated list of interface names. #define CELIX_RSA_INTERFACES_OF_PORT_PREFIX "CELIX_RSA_INTERFACES_OF_PORT_" +//The config property for the ranking offset of imported services. The value is a comma-separated list of <config type>=<ranking offset>. e.g. CELIX_RSA_IMPORTED_SERVICE_RANKING_OFFSETS="celix.remote.admin.shm=-1,org.amdatu.remote.admin.http=-2". The ranking offset will be added to the original service ranking of the imported service. This allows the user to configure the ranking of imported services based on different configuration types. Review Comment: nitpick: split up the comment over multiple lines (ColumnLimit in .clang-format is 120). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
