pnoltes commented on code in PR #845:
URL: https://github.com/apache/celix/pull/845#discussion_r3944899976
##########
.github/workflows/conan_create.yml:
##########
@@ -67,6 +67,31 @@ jobs:
CXX: ${{ matrix.compiler[1] }}
run: |
conan create . -c tools.cmake.cmaketoolchain:generator=Ninja -b
missing -o celix/*:build_all=True -o celix/*:enable_ccache=True -pr:b default
-pr:h default -s:h build_type=${{ matrix.type }} -o celix/*:celix_cxx17=True -o
celix/*:celix_install_deprecated_api=True -o mosquitto/*:broker=True -o
*:shared=True
+ - name: Generate CycloneDX SBOM from canonical Conan lockfile
+ if: matrix.compiler[0] == 'gcc'
+ run: |
+ rm -rf sbom
+ conan install . \
+ --lockfile=conan/safe-defaults.lock \
Review Comment:
I think we also need to use the lockfile for the `conan create` command. To
ensure that both commands use the same deps (and do not build libs twice).
I also think we should use the lock file in the rest of the conan builds.
This ensures that the CI builds are reproducible, including upstream
dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
