PengZheng commented on code in PR #848:
URL: https://github.com/apache/celix/pull/848#discussion_r4002124939
##########
.github/workflows/coverage.yml:
##########
@@ -72,7 +72,7 @@ jobs:
source generators/conanrun.sh
make coverage
source generators/deactivate_conanrun.sh
- lcx="lcov --output-file=coverage.info " && for i in `find . -name
"*.info.cleaned"`; do lcx+=" --add-tracefile=$i"; done && $lcx
+ lcx="lcov --output-file=coverage.info --ignore-errors
inconsistent,mismatch" && for i in `find . -name "*.info.cleaned"`; do lcx+="
--add-tracefile=$i"; done && $lcx
Review Comment:
AI tolds me that
```CMake
# lcov 2.x errors on gcov end-line inconsistencies for functions sharing
a
# start line (e.g. gtest TEST_F bodies and their synthesized ctor/dtors)
and
# on unused exclude patterns; 1.x neither has these checks nor accepts
the
# corresponding --ignore-errors categories (unknown categories are fatal
in
# all versions), so the flags are version-gated.
```
I have not verified the 1.x behavior, which needed to be done to decide how
to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
