[ 
https://issues.apache.org/jira/browse/CMIS-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201288#comment-17201288
 ] 

Manisha Sapiah commented on CMIS-1107:
--------------------------------------

Hi [~fmui],

As stated above, even though the value for parameter includeRelationships is 
sent as *NONE* and till (class serve:470, ObjectService$GetObject 
(org.apache.chemistry.opencmis.server.impl.atompub) this value remains same but 
due to below piece of code the value is is changed to BOTH, since this 
hardcoded.
{code:java}
public ObjectInfo getObjectInfo(String repositoryId, String objectId) {
        Map<String, ObjectInfo> oim = getObjectInfoMap();
        ObjectInfo info = oim.get(objectId);
        if (info == null) {
            // object info has not been found -> create one
            try {
                // switch off object info collection to avoid side effects
                addObjectInfos = false;

                // get the object and its info
                ObjectData object = getObject(repositoryId, objectId, null, 
Boolean.TRUE, IncludeRelationships.BOTH,
                        "*", Boolean.TRUE, Boolean.FALSE, null);
                info = getObjectInfoIntern(repositoryId, object);

                // switch on object info collection
                addObjectInfos = true;

                // add object info
                addObjectInfo(info);
            } catch (Exception e) {
                info = null;

                if (LOG.isTraceEnabled()) {
                    LOG.trace("Getting the object info for object {} in 
repository {}  failed: {}", objectId,
                            repositoryId, e.toString(), e);
                }
            } finally {
                addObjectInfos = true;
            }
        }
        return info;
    }
{code}
Which is resulting in change. All this is happening in the apache layer.

Regards,
Manisha

> AbstractCmisService class is not taking inputs as passed in the ObjectService
> -----------------------------------------------------------------------------
>
>                 Key: CMIS-1107
>                 URL: https://issues.apache.org/jira/browse/CMIS-1107
>             Project: Chemistry
>          Issue Type: Bug
>          Components: opencmis-commons
>            Reporter: Manisha Sapiah
>            Assignee: Florian Müller
>            Priority: Blocker
>         Attachments: image-2020-09-21-19-10-45-895.png
>
>
> Whenever we are trying to getObject for atompub binding, we see the parameter 
> includeRelationships is set to BOTH in the AbstractCmisService 
> (*getObjectInfo:1059, AbstractCmisService 
> (org.apache.chemistry.opencmis.commons.impl.server)* due to method 
> getObjectInfo.
> While the value passed in the ObjectService is NONE *(class serve:470, 
> ObjectService$GetObject (org.apache.chemistry.opencmis.server.impl.atompub)* 
> which can be seen in the attachment:
> !image-2020-09-21-19-10-45-895.png!
> This is causing a behavior change and a performance issue.
> We are using chemistry-opencmis-0.13.0 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to