It should be removed then, imo.

Regards,
Alan

On Sep 8, 2014, at 6:56 PM, Eric Yang <[email protected]> wrote:

> It is not needed.  The empty file is left from CHUKWA-495. Where the file
> has been refactored into two other files. I will remove it from trunk.
> 
> +1 on the release.
> 
> regards,
> Eric
> 
> On Mon, Sep 8, 2014 at 10:28 AM, Alan D. Cabrera <[email protected]>
> wrote:
> 
>> 
>> On Sep 7, 2014, at 5:28 PM, Eric Yang <[email protected]> wrote:
>> 
>>> Hi Alan,
>>> 
>>> I took another pass, and found the stop words have license header on
>> them.
>>> Some files are Apache Licensed, and some are BSD licensed.  License
>>> information are correct on stop words files.  Velocity css and js files
>>> don't work correctly when headers are added.  Therefore, the only file
>> that
>>> doesn't have a proper license is ChukwaStorage.java, which is an empty
>>> file.  I don't know if we want to hold up the release on an empty file.
>> 
>> I agree, no need to hold up the release on an empty file.  Is it really
>> needed if it’s empty?  If it’s needed then it needs a license.
>> 
>> 
>> Regards,
>> Alan
>> 
>> 

Reply via email to