Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/122#issuecomment-61103018
Looking good so far @lewismc. However, I think we should declare the
project dependencies in the setup.py before we merge this in if we're going to
host on PyPI. At the very least users will be notified if their lacking
something if they try to `pip install` the package then. At the moment this
will just pretend like everything is peachy and then die when they try to run
something and that doesn't feel terribly user friendly. Thoughts?
> Additionally, I suggest that we thoroughly test the egg which we would
download prior to pushing this with the next release of OODT.
Could you elaborate on what we would do with OODT here?? It's early so I
might just be a bit dense at the moment =)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---