[
https://issues.apache.org/jira/browse/CLIMATE-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202730#comment-14202730
]
ASF GitHub Bot commented on CLIMATE-552:
----------------------------------------
GitHub user MJJoyce opened a pull request:
https://github.com/apache/climate/pull/130
CLIMATE-552 - TLC for local.py
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MJJoyce/climate CLIMATE-552
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #130
----
commit 99b57325dbe9750f237f5b3ff32fabc92ab3e9f0
Author: Michael Joyce <[email protected]>
Date: 2014-11-07T19:06:20Z
CLIMATE-552 - Drop unused private functions from local.py
commit 3992e0c61058770df7d4df90347e0e910db4dddc
Author: Michael Joyce <[email protected]>
Date: 2014-11-07T19:09:07Z
CLIMATE-552 - Remove dead code from local.py
commit 32a9bd192dcd7e96f7e71061bffe86f20db3d563
Author: Michael Joyce <[email protected]>
Date: 2014-11-07T20:00:08Z
CLIMATE-552 - Comments and minor code cleanup
- Cleanup doc strings and in-line documentation.
- Remove unneeded list conversions of sets.
commit f3badc99981dc6dff3a74e67433b048c3e5aab57
Author: Michael Joyce <[email protected]>
Date: 2014-11-07T21:22:26Z
CLIMATE-552 - Line length fixes and readability fixes
- Correct PEP-8 incompatible line lengths.
- Adjust variable name and add additional comments to load_file for
clarity.
commit 55ac17798c071a923ce807cc6fc2e0894e972a8e
Author: Michael Joyce <[email protected]>
Date: 2014-11-07T21:29:14Z
CLIMATE-552 - Clean up imports in local.py
----
> Cleanup local.py data source
> ----------------------------
>
> Key: CLIMATE-552
> URL: https://issues.apache.org/jira/browse/CLIMATE-552
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Components: data sources
> Affects Versions: 0.4
> Reporter: Michael Joyce
> Assignee: Michael Joyce
> Fix For: 0.5
>
>
> There's a good bit of dead and commented out code in local.py. It could use a
> bit of a spring cleaning to get everything in tip top shape.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)