Github user huikyole commented on the pull request:
https://github.com/apache/climate/pull/143#issuecomment-70346251
Thank you very much for your review.
There is a similar function named plotAccuInTimeRange in
https://github.com/apache/climate/blob/master/mccsearch/code/mccSearch.py,
although this function only works for TRMM data that Kim has used.
Some changes have been amended.
1. Hard coded file paths have been removed.
2. No space near '=' for keyword parameters.
3. All of the print statements have been removed.
Somehow, users of load_files want to check the name of netCDF files. For
example, if we want to look at summer time precipitation datasets for 2006,
there are 92 files to read for each simulation. Do you have a better suggestion
other than removing 'print'?
Currently, OCW assumes that all the datasets are regularly gridded. If we
spatially subset some model outputs whose data are irregularly gridded,
value_dim = 2 and values.shape = (time_count, grid_count). I would suggest
commenting out 'utils.normalize_lat_lon_values' in class Dataset because the
assumption of data structure does not make any sense for the irregularly
gridded data.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
