Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/145#issuecomment-70756158
Hey @huikyole, please check the above. Didn't have a ton of time to dig
through all of the code, but caught a few things quickly. Please write some
tests for this as well. Seems like a significant enough change to warrant a few
tests. Additionally, the JIRA ticket isn't being mirrored properly. Please
update the PR title to read
"CLIMATE-564 - ..."
That should fix it!
Thanks again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
