Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/111#issuecomment-96043711
@huikyole This PR needs cleaning.
For e.g. what your tix says, and what work has been done here don't align.
Please be certain to include the other functionality attached to this PR e.g.
allowing temporal subsetting in your doc string associated with this pull
request.
Also, please note that there have been changes to the codebase since this
PR was submitted. Given the functionality in the utils class and the
replication here, I wonder if one can include the manipulations on the DS times
parameter the suggested "temporal_subset" function to the
calc_climatology_season in the utils class instead.
Also, it is unclear how the new "spatial_aggregation" functionality is
different to that from the Bounds object.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
