[
https://issues.apache.org/jira/browse/CLIMATE-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511606#comment-14511606
]
ASF GitHub Bot commented on CLIMATE-467:
----------------------------------------
Github user kwhitehall commented on the pull request:
https://github.com/apache/climate/pull/111#issuecomment-96043711
@huikyole This PR needs cleaning.
For e.g. what your tix says, and what work has been done here don't align.
Please be certain to include the other functionality attached to this PR e.g.
allowing temporal subsetting in your doc string associated with this pull
request.
Also, please note that there have been changes to the codebase since this
PR was submitted. Given the functionality in the utils class and the
replication here, I wonder if one can include the manipulations on the DS times
parameter the suggested "temporal_subset" function to the
calc_climatology_season in the utils class instead.
Also, it is unclear how the new "spatial_aggregation" functionality is
different to that from the Bounds object.
> Handling various calendar types
> -------------------------------
>
> Key: CLIMATE-467
> URL: https://issues.apache.org/jira/browse/CLIMATE-467
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Components: regridding/data processing
> Affects Versions: 0.3-incubating
> Reporter: Huikyo Lee
> Assignee: Huikyo Lee
> Priority: Minor
> Fix For: 1.0.0
>
>
> utils.decode_time_values needs to be updated so that we can handle daily data
> with various calendar types (ex) 'gregorian', '365 day', '360 day').
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
