[ 
https://issues.apache.org/jira/browse/CLIMATE-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573641#comment-14573641
 ] 

ASF GitHub Bot commented on CLIMATE-583:
----------------------------------------

GitHub user MJJoyce opened a pull request:

    https://github.com/apache/climate/pull/205

    CLIMATE-583 - Better config based evaluation plot support

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MJJoyce/climate config-work

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/climate/pull/205.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #205
    
----
commit f316aefcc4ae731f2e88b1bbd4b007948417f5e0
Author: Michael Joyce <jo...@apache.org>
Date:   2015-05-15T15:22:34Z

    CLIMATE-583 - Add Taylor diagram support

commit ba8556287b3558eb6554a32596976c6a9ae98b11
Author: Michael Joyce <jo...@apache.org>
Date:   2015-06-01T22:09:18Z

    CLIMATE-583 - Allow for partial evaluation runs
    
    Allow for a user to do partial evaluation runs by specifying that config
    parsing errors should be ignored. For instance, suppose that a user
    wants to generate only a subregion plot. Normally they would have to
    load and run a fake evaluation just to get the subregion plot. With this
    new optional argument the user can pass only subregion information and
    plot information in the config and still run the evaluation.
    
    Note, there are no guarantees that any partial evaluation will work.
    This option gives the user plenty of rope to hang themselves and should
    really only be used when you want to generate plots that don't require a
    full evaluation run (such as subregion plots).
    
    - Add optional command line arg that tells the parser/runner to ignore
      config parsing errors. This will cause the evaluation to "run" even if
      the configuration isn't value.
    - When running an evaluation, only run if the evaluation object passes
      an is_valid check. Normally this is done in the evaluation object
      anyway when calling run but calling this early prevents error messages
      from being dumped.
    - Make evaluation creation a bit more robust. Instead of just assuming
      that 'datasets' is always present we first check that the value is not
      None in the config before trying to check for 'reference' or
      'targets'. Similarly with metrics. This is necessary for "partial"
      evaluations.

commit f9e13d7f4bb737d54b71b8bdd71b9b786be833e9
Author: Michael Joyce <jo...@apache.org>
Date:   2015-06-01T22:01:46Z

    CLIMATE-583 - Add subregion plot support
    
    - Move subregion checking above plot validity checks.
    - When checking for plots, if the config is deemed valid then we need to
      check to ensure that subregion information is provided for the plots
      that require it. At the moment this check is only done for subregion
      plots.
    - Add required keys for subregion plots

commit c8539d009d1eefe0efa59d4c554f66c95f12928e
Author: Michael Joyce <jo...@apache.org>
Date:   2015-06-04T16:50:24Z

    CLIMATE-583 - Add portrait diagram support

commit d6be7cf6266988e7e08305f5cfa481105875f2e7
Author: Michael Joyce <jo...@apache.org>
Date:   2015-06-04T21:22:19Z

    CLIMATE-583 - Add time series plot support

----


> Add better plot support to config based evaluations
> ---------------------------------------------------
>
>                 Key: CLIMATE-583
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-583
>             Project: Apache Open Climate Workbench
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 0.5
>            Reporter: Michael Joyce
>            Assignee: Michael Joyce
>             Fix For: 1.0.0
>
>
> At the moment only contour maps are supported in our config. We need to add 
> support for all of our supported plot types.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to