[
https://issues.apache.org/jira/browse/CLIMATE-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131359#comment-15131359
]
ASF GitHub Bot commented on CLIMATE-750:
----------------------------------------
GitHub user veduardo opened a pull request:
https://github.com/apache/climate/pull/307
CLIMATE-750 - Fix a String comparison that should be against a Boolean.
Hi there,
Fixed it.
Let me know if you think anything else could be improved.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/veduardo/climate CLIMATE-750
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/307.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #307
----
commit ba93aeb2e625a438a31c47e70f880aeeab8089b5
Author: Vinicius Silva <[email protected]>
Date: 2016-02-03T23:16:32Z
CLIMATE-750 - Fix a string comparison that should be against a boolean.
----
> $scope.fileLoadFailed Compares On Boolean Rather Than String
> ------------------------------------------------------------
>
> Key: CLIMATE-750
> URL: https://issues.apache.org/jira/browse/CLIMATE-750
> Project: Apache Open Climate Workbench
> Issue Type: Bug
> Reporter: Michael Anderson
> Priority: Trivial
>
> $scope.fileLoadFailed is set using a Boolean:
> $scope.fileLoadFailed = true;
> $scope.fileLoadFailed = false;
> but the conditional treats it as a string and always fails:
> if($scope.fileLoadFailed === 'false'){
> Update comparison to compare as a boolean.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
