[
https://issues.apache.org/jira/browse/CLIMATE-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337722#comment-15337722
]
ASF GitHub Bot commented on CLIMATE-812:
----------------------------------------
Github user jarifibrahim commented on a diff in the pull request:
https://github.com/apache/climate/pull/361#discussion_r67598737
--- Diff: ocw/dataset_processor.py ---
@@ -51,107 +53,114 @@ def temporal_subset(month_start, month_end,
target_dataset, average_each_year=Fa
"""
if month_start > month_end:
- month_index = range(month_start,13)
- month_index.extend(range(1, month_end+1))
+ month_index = range(month_start, 13)
+ month_index.extend(range(1, month_end + 1))
else:
- month_index = range(month_start, month_end+1)
+ month_index = range(month_start, month_end + 1)
dates = target_dataset.times
months = np.array([d.month for d in dates])
time_index = []
for m_value in month_index:
time_index = np.append(time_index, np.where(months == m_value)[0])
- if m_value == month_index[0]:
- time_index_first = np.min(np.where(months == m_value)[0])
--- End diff --
The `time_index_first` and `time_index_last` variables are not used
anywhere.
> Fix PEP8 Violations in dataset processor
> ----------------------------------------
>
> Key: CLIMATE-812
> URL: https://issues.apache.org/jira/browse/CLIMATE-812
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Reporter: Ibrahim Jarif
> Assignee: Ibrahim Jarif
> Fix For: 1.1
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
