[jira] [Commented] (CLIMATE-486) Normalize DSP function parameter ordering

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/CLIMATE-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397580#comment-15397580
 ] 

ASF GitHub Bot commented on CLIMATE-486:
----------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/climate/pull/375
  
    
    [![Coverage 
Status](https://coveralls.io/builds/7203962/badge)](https://coveralls.io/builds/7203962)
    
    Coverage decreased (-0.1%) to 83.535% when pulling 
**1398a868b89222d834b5b28cc4856be85241e647 on jarifibrahim:CLIMATE-486** into 
**e823b03c9ba732f42909ad7b5e5b1a41fa321824 on apache:master**.



> Normalize DSP function parameter ordering 
> ------------------------------------------
>
>                 Key: CLIMATE-486
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-486
>             Project: Apache Open Climate Workbench
>          Issue Type: Improvement
>          Components: regridding/data processing
>    Affects Versions: 0.3-incubating
>            Reporter: Michael Joyce
>            Assignee: Ibrahim Jarif
>              Labels: Newcomer
>             Fix For: 1.2.0
>
>
> Some of the DSP functions (namely subset and safe_subset) have parameter 
> orderings that aren't consistent with the other DSP functions. The general 
> ordering seems to be dsp.function(dataset(s), other, things). We should get 
> all of the function signatures on the same page to keep everything pretty and 
> user friendly. If we change the signatures of some of the functions were 
> going to need to make sure to update the examples as well!
> Note, there might be other functions besides the two mentioned that need to 
> be reordered, those are just the ones I saw at first glance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)