[
https://issues.apache.org/jira/browse/CLIMATE-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419111#comment-15419111
]
ASF GitHub Bot commented on CLIMATE-827:
----------------------------------------
Github user huikyole commented on the pull request:
https://github.com/apache/climate/commit/02dfdec65adb81cdc659764008045e99f61bbf4d#commitcomment-18625579
In ocw/dataset.py:
In ocw/dataset.py on line 314:
Hi Ibrahim,
The boundary limits are checked once a user create a Bounds object.
Sometimes, there is a problem of the previous boundary check inside subset
module.
For example,
In the rectangular boundary,
lat_min = -45 & lat_max = 30.25
In the OCW dataset,
dataset.lats = [-90, -88, -86, -84, -82, …, -48, -46, -44, …, 26, 28, 30,
32, 34, …]
subset_dataset.lats = [-44, -42, …, 26, 28, 30]
So with the subset_dataset.lats, the previous boundary check will raise
Errors Because -45 < -44 and 30.25 >30.
Thanks,
Kyo
From: Ibrahim Jarif <[email protected]>
Reply-To: apache/climate <[email protected]>
Date: Friday, August 12, 2016 at 3:53 AM
To: apache/climate <[email protected]>
Cc: Huikyo Lee <[email protected]>, Mention
<[email protected]>
Subject: Re: [apache/climate] CLIMATE-827 - Adding spatial masking options
(02dfdec)
@huikyole<https://github.com/huikyole> Shouldn't we check this in some kind
of setter method? The values are checked only when the object is created. I can
later modify the lat_min/max values and there won't be any exception raised.
This would be wrong, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on
GitHub<https://github.com/apache/climate/commit/02dfdec65adb81cdc659764008045e99f61bbf4d#commitcomment-18620602>,
or mute the
thread<https://github.com/notifications/unsubscribe-auth/AHdS-NMnRq2ZJUS6fkNIEzLqGQMpHelOks5qfFCNgaJpZM4Ji-oA>.
> Adding spatial masking options
> ------------------------------
>
> Key: CLIMATE-827
> URL: https://issues.apache.org/jira/browse/CLIMATE-827
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Affects Versions: 1.0.0
> Reporter: Huikyo Lee
> Assignee: Huikyo Lee
> Fix For: 1.2.0
>
>
> With this patch, users can use an array of country or US state names to
> extract or mask OCW datasets.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
