Github user huikyole commented on a diff in the pull request:

    https://github.com/apache/climate/pull/434#discussion_r111779716
  
    --- Diff: ocw/dataset_processor.py ---
    @@ -391,8 +391,11 @@ def subset(target_dataset, subregion, 
subregion_name=None, extract=True, user_ma
         '''
     
         if not subregion.start:
    -        subregion.start = target_dataset.times[0]
    -        subregion.end = target_dataset.times[-1]
    +        time_start = target_dataset.times[0]
    --- End diff --
    
    Thanks, @agoodm . I defined time_start and time_end not to change the 
subregion object in case the object is used again for subsetting another OCW 
dataset. I will update the test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to