[ https://issues.apache.org/jira/browse/CLIMATE-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333771#comment-16333771 ]
ASF GitHub Bot commented on CLIMATE-947: ---------------------------------------- Github user huikyole commented on the issue: https://github.com/apache/climate/pull/496 @agoodm I had to run dos2unix first to remove ^M characters. Could you review this PR? > Updates in cordex.py > -------------------- > > Key: CLIMATE-947 > URL: https://issues.apache.org/jira/browse/CLIMATE-947 > Project: Apache Open Climate Workbench > Issue Type: Improvement > Affects Versions: 1.2.0 > Reporter: Huikyo Lee > Assignee: Huikyo Lee > Priority: Minor > Fix For: 1.3.0 > > > A RCMES user made several suggestions to improve cordex.py. The goal is to > facilitate building a RCMES docker image. > * the variable 'errored' needs to be defined outside a for loop. > * It would be better to make domain, workdir, obs_dir, and models_dir become > input parameters. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)