[ 
https://issues.apache.org/jira/browse/CLIMATE-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335374#comment-16335374
 ] 

ASF GitHub Bot commented on CLIMATE-826:
----------------------------------------

Github user huikyole commented on a diff in the pull request:

    https://github.com/apache/climate/pull/477#discussion_r163141416
  
    --- Diff: examples/model_ensemble_to_rcmed.py ---
    @@ -125,6 +125,11 @@
         wrf311_dataset, temporal_resolution='annual')
     cru31_dataset = dsp.temporal_rebin(cru31_dataset, 
temporal_resolution='annual')
     
    +# Rebinning annual pushes the start date to the middle of the year
    --- End diff --
    
    The original script compares the annual means for the year 1989 between cru 
(observation), two models, and an average of the models. I think using the 
start and end times of (1989, 1, 1) and (1989, 12, 1) are totally okay and 
drawing three plots for the three model datasets is reasonable.


> ValueError in model_ensemble_to_rcmed.py
> ----------------------------------------
>
>                 Key: CLIMATE-826
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-826
>             Project: Apache Open Climate Workbench
>          Issue Type: Bug
>            Reporter: Ibrahim Jarif
>            Assignee: Michael Anderson
>            Priority: Critical
>             Fix For: 1.3.0
>
>
> {code}Traceback (most recent call last):
>   File 
> "/home/travis/build/jarifibrahim/climate/examples/model_ensemble_to_rcmed.py",
>  line 134, in <module>
>     knmi_dataset = dsp.subset(new_bounds, knmi_dataset)
>   File "build/bdist.linux-x86_64/egg/ocw/dataset_processor.py", line 388, in 
> subset
>   File "build/bdist.linux-x86_64/egg/ocw/dataset_processor.py", line 1408, in 
> _are_bounds_contained_by_dataset
> ValueError: bounds.start: 1989-01-01 00:00:00 is not between start: 
> 1989-07-02 00:00:00 and end: 2008-07-02 00:00:00{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to