----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11640/#review21464 -----------------------------------------------------------
http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11640/#comment44461> This assignment to variable 'means' is not used, since the variable is reused in the next line. http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11640/#comment44462> Drop this line as well. Variable is un-used. http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11640/#comment44463> I prefer these lines be deleted. If they are needed for documentation purposes, then they should be moved up into the function's docstring block. http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11640/#comment44464> More comments to be removed. http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11640/#comment44465> Kyo, There are several spots in this function where I started to work on using SubRegion objects. I am going to note each block that needs to remain unchanged below. I will just mark the lines of code and leave the 'SubRegions Work' in the comment. http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11640/#comment44466> SubRegions Work - fileOutputOption is referenced later in the code as part of the clean up. It is just more descriptive than FoutOption http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11640/#comment44467> SubRegions Work http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11640/#comment44468> SubRegions Work http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11640/#comment44469> SubRegions Work http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11640/#comment44470> SubRegions Work http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11640/#comment44471> SubRegions Work http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11640/#comment44473> SubRegions Work http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11640/#comment44474> SubRegions Work http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11640/#comment44475> SubRegions Work http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11640/#comment44476> SubRegions Work http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11640/#comment44477> Kyo, If you can confirm that these two variables are not needed in the current code, then lets from the TODO, tempRMS and tempCOR from the code as well. When i was in here doing work, my IDE flagged these as un-used variables. http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11640/#comment44478> SubRegions Work http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11640/#comment44479> SubRegions Work - Cameron Goodale On June 4, 2013, 10:25 p.m., Kyo Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11640/ > ----------------------------------------------------------- > > (Updated June 4, 2013, 10:25 p.m.) > > > Review request for Apache Open Climate. > > > Description > ------- > > We have not applied the changes in metrics.py that I made several months ago. > > https://oodt.jpl.nasa.gov/review/r/155/ > > Kim and I will clean up metrics.py > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py > 1489653 > > Diff: https://reviews.apache.org/r/11640/diff/ > > > Testing > ------- > > RCMES worked with NARCCAP model outputs and AIRS temperature data. > > > Thanks, > > Kyo Lee > >
