> On June 11, 2013, 4:54 a.m., Cameron Goodale wrote: > > http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/plots.py, > > lines 218-235 > > <https://reviews.apache.org/r/11791/diff/1/?file=303267#file303267line218> > > > > Alex, > > > > I see that this function has been completely removed. Was that by > > design?
Yes, from looking at the code for this and draw_cntr_map_single(), both of them were ultimately making filled contour maps albeit in slightly different ways. For now I decided it would be most sensible to keep one standard function for doing this. To my knowledge the other one wasn't being used for the current plotting in metrics, so I chose to remove it. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11791/#review21684 ----------------------------------------------------------- On June 11, 2013, 5:09 a.m., Alex Goodman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11791/ > ----------------------------------------------------------- > > (Updated June 11, 2013, 5:09 a.m.) > > > Review request for Apache Open Climate, Cameron Goodale and Kyo Lee. > > > Description > ------- > > To help aid Kyo in his efforts to eradicate all traces of PyNIO and PyNGL > from RCMES, as well as jump start my own large scale revamp of the plotting > toolkit, I have rewritten the draw_cntr_map_single() function using > matplotlib. I also removed old or unused functions. > > Note that this adds a new dependency, mpl_toolkits.basemap, which can be a > little complicated to build directly from source if you don't have GEOS > installed (though considerably less so than PyNIO / PyNGL overall) > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/plots.py > 1491638 > > Diff: https://reviews.apache.org/r/11791/diff/ > > > Testing > ------- > > Plotted a contour map of a random input array generated via > numpy.random.rand(). > > > Thanks, > > Alex Goodman > >
