Hi Paul, I see what you are saying and I generally agree that we shouldn't let ourselves be held up by corner cases. However, the nature of this problem is that the code would fail to run when the domain of longitudes was only between 180 and 360. This means that RCMES would break entirely when processing any RCM output covering only North America (eg NARCCAP) for example, so from the perspective of a scientist I would see that as reason alone to hold off on making an official release until this is fixed. Perhaps calling it a "corner case" might have underestimated its importance.
The actual fix for this was very trivial though and took a mere extra two lines of code. I understand that it might be troublesome to keep rolling out new release candidates due to seemingly minor issues like this, but I am fairly confident that after this change it should be ready for release, so I see no reason not to put the fixed version of the code in 0.1. Thanks, Alex On Fri, Jul 26, 2013 at 10:18 PM, Ramirez, Paul M (398J) < [email protected]> wrote: > It's a corner case I say no need to -1 and can be fixed in 0.2. Seems like > we have been chasing ourselves on this one. > > Here's my +1, Binding. > > --Paul > > On 7/26/13 10:14 PM, "Goodman, Alexander (398J-Affiliate)" > <[email protected]> wrote: > > >Tentative -1. > > > >Kyo discovered a bug in files.py after testing RC5 with NARCCAP model data > >(see CLIMATE-221). It was a strange corner case. I have since fixed it and > >committed the changes to the trunk, so if you roll out another RC with > >those changes incorporated in I think then it would be ready for release. > > > > > >On Thu, Jul 25, 2013 at 9:00 AM, Cameron Goodale <[email protected]> > >wrote: > > > >> Hello again Devs, > >> > >> Release Candidate 5 is ready to test. We are using an svn diet repo. > >> Please be sure to grab rc5 from the list (rc4 is still there as well) > >> > >> https://dist.apache.org/repos/dist/dev/incubator/climate/ > >> > >> Please download the files and let me know if you find any issues. > >> > >> Vote will be open for at least 72 Hours: > >> > >> Only votes from Incubator PMC are binding, but folks are welcome to > >> check the release candidate and voice their approval or disapproval. > >> The vote passes if at least three binding +1 votes are cast. > >> > >> [ ] +1 Release the packages as Apache Open Climate Workbench > >>0.1-incubating > >> > >> [ ] -1 Do not release the packages because... > >> > >> > >> Best Regards, > >> > >> > >> Cameron Goodale > >> > > > > > > > >-- > >Alex Goodman > > -- Alex Goodman
