[
https://issues.apache.org/jira/browse/CLIMATE-274?focusedWorklogId=14836&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-14836
]
Cameron Goodale logged work on CLIMATE-274:
-------------------------------------------
Author: Cameron Goodale
Created on: 22/Aug/13 16:22
Start Date: 22/Aug/13 16:21
Worklog Time Spent: 1.5h
Work Description: Coded up the changes and put a patch on review board.
https://reviews.apache.org/r/13738/
Issue Time Tracking
-------------------
Worklog Id: (was: 14836)
Time Spent: 1.5h
Remaining Estimate: 0.5h (was: 2h)
> Make the exception that the Dataset class throws more descriptive
> -----------------------------------------------------------------
>
> Key: CLIMATE-274
> URL: https://issues.apache.org/jira/browse/CLIMATE-274
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Components: data sources, general
> Affects Versions: 0.2-incubating
> Environment: OS X
> Reporter: Cameron Goodale
> Assignee: Cameron Goodale
> Fix For: 0.3-incubating
>
> Original Estimate: 2h
> Time Spent: 1.5h
> Remaining Estimate: 0.5h
>
> When a new Dataset Object is initialized the parameters that are required (4
> total) are all checked individually as well as together, and if any of these
> tests fail a ValueError is raised with the following message to the user:
> "Dataset given improperly shaped array during initialization."
> I would like to try and make that error message more specific about which one
> of the checks raised the error.
> Example Messages:
> --------------------------------
> * Longitude Array is not 1 dimension
> * Latitude Array is not 1 dimension
> * Times Array is not 1 dimension
> * Times Array doesn't contain datetime objects
> * Values Arrays is not 3 dimensional
> * Values Array is out of order. Expected (times, lat, lon) but got ([what
> ever we discovered] lon, times, lat)
> To some people this amount of check and rigor might seem overkill, but I
> think this is necessary since the rest of the OCW code depends on have a
> properly formed OCW Dataset object to work with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
