[
https://issues.apache.org/jira/browse/CLIMATE-281?focusedWorklogId=14847&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-14847
]
Cameron Goodale logged work on CLIMATE-281:
-------------------------------------------
Author: Cameron Goodale
Created on: 28/Aug/13 19:22
Start Date: 28/Aug/13 19:21
Worklog Time Spent: 1h
Work Description: Committed revision 1518315.
Fixed the issues listed in this JIRA after discussing the changes with Mike J
to make sure I wasn't violating the original design intent.
Issue Time Tracking
-------------------
Worklog Id: (was: 14847)
Time Spent: 1h
Remaining Estimate: 1h (was: 2h)
> Evaluation Class methods need 'self' added to them
> --------------------------------------------------
>
> Key: CLIMATE-281
> URL: https://issues.apache.org/jira/browse/CLIMATE-281
> Project: Apache Open Climate Workbench
> Issue Type: Sub-task
> Components: analysis
> Affects Versions: 0.2-incubating
> Environment: Mac OS X
> Reporter: Cameron Goodale
> Assignee: Cameron Goodale
> Fix For: 0.3-incubating
>
> Original Estimate: 2h
> Time Spent: 1h
> Remaining Estimate: 1h
>
> While using the Evaluation Class I kept getting this error:
> NameError: global name '_should_run_regular_metrics' is not defined
> I looked at the method, and it should be prepend with 'self.' when calling
> it. I also noticed other private methods didn't include self in their
> function definition.
> _run_no_subregion_evaluation() vs. _run_no_subregion_evaluation(self)
> _should_run_regular_metrics() vs. _should_run_regular_metrics(self)
> This issue will fix these issue by adding more self to the Class definition.
> I also plan to add some new tests to run a couple evaluations and exercise
> the run() method a bit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
