----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15428/ -----------------------------------------------------------
(Updated Nov. 12, 2013, 4:34 p.m.) Review request for Apache Open Climate. Repository: climate Description ------- SubRegion Index slicing was failing if you used different start time and end time values other than exact dataset time values. The new changes are to select the closest time from dataset time list after the user given start_time and closest time in dataset time list before user given end_time. Diffs (updated) ----- http://svn.apache.org/repos/asf/incubator/climate/trunk/ocw/dataset_processor.py 1540781 http://svn.apache.org/repos/asf/incubator/climate/trunk/ocw/tests/test_dataset_processor.py 1540781 Diff: https://reviews.apache.org/r/15428/diff/ Testing ------- I added one more unittest function to test non exact time temporal bound (function test_subset_using_non_exact_temporal_bounds()). boustani-2691427:tests MBoustani$ python test_dataset_processor.py ....................... ---------------------------------------------------------------------- Ran 23 tests in 169.703s OK File Attachments ---------------- test of dataset processor https://reviews.apache.org/media/uploaded/files/2013/11/12/545a7ea6-d09a-458d-b29c-7f32b34bf0fc__test_dataset_processor.batch Dataset processor python file https://reviews.apache.org/media/uploaded/files/2013/11/12/cff82fbd-483e-48fe-8b93-97ae74dc2600__dataset_processor.batch Thanks, Maziyar Boustani
