----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17727/#review33700 -----------------------------------------------------------
Ship it! Looks good to me - Michael Joyce On Feb. 5, 2014, 6:08 p.m., Maziyar Boustani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17727/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2014, 6:08 p.m.) > > > Review request for Apache Open Climate. > > > Repository: climate > > > Description > ------- > > This unittest tests the Class Bias from metrics.py module. > > Test cases: > - To test bias function between reference dataset and itself > - To test bias function between reference dataset and target dataset > - To test bias function between target dataset and reference dataset > - To test bias function between one dataset and one non-dataset > - To test bias function between two different datasets > > > Diffs > ----- > > > https://svn.apache.org/repos/asf/incubator/climate/trunk/ocw/tests/test_metrics.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/17727/diff/ > > > Testing > ------- > > Running code result: > boustani-2691427:tests MBoustani$ python test_metrics.py > ..... > ---------------------------------------------------------------------- > Ran 5 tests in 0.002s > > OK > > > Pylint result: > Global evaluation > ----------------- > Your code has been rated at 7.92/10 (previous run: 7.92/10, +0.00) > > > Thanks, > > Maziyar Boustani > >
