----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17816/#review33843 -----------------------------------------------------------
Ship it! Just simple comment. Looks great. http://svn.apache.org/repos/asf/incubator/climate/trunk/ocw/tests/test_metrics.py <https://reviews.apache.org/r/17816/#comment63460> This import statement will get pretty long as more and more tests are added to this file. An alternative approach would be something like: from ocw import metrics Then down in the code we need to pre-pend metrics. to the metric classes (Bias and TemporalStdDev). This isn't something that needs to be fixed in this version, but we should address it soon. - Cameron Goodale On Feb. 6, 2014, 8:17 p.m., Maziyar Boustani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17816/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2014, 8:17 p.m.) > > > Review request for Apache Open Climate. > > > Repository: climate > > > Description > ------- > > Class TestTemporalStdDev has been added on test_metrics.py to test Class > TestTemporalStdDev on metrics.py module. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/climate/trunk/ocw/tests/test_metrics.py > 1565348 > > Diff: https://reviews.apache.org/r/17816/diff/ > > > Testing > ------- > > boustani-2691427:tests MBoustani$ python test_metrics.py > .. > ---------------------------------------------------------------------- > Ran 2 tests in 0.022s > > OK > > > Pylint result: > Global evaluation > ----------------- > Your code has been rated at 7.73/10 (previous run: 7.73/10, +0.00) > > > Thanks, > > Maziyar Boustani > >
