[
https://issues.apache.org/jira/browse/CLIMATE-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913559#comment-13913559
]
Maziyar Boustani commented on CLIMATE-349:
------------------------------------------
Mike, Alex,
I am thinking maybe we have an issue here with "reshapeMonthlyData" function
from [1].
I understand we are trying to add another shape to the dataset's shape (number
of year) for later usage, however having month as 12 hardcoded may not be a
correct choice.
For example:
If dataset has 25 month, 90 latitude and 180 longitude, then shape of
dataset is (25,90,180)
Based on "reshapeMonthlyData" function:
nMonth = 25
nshape = 25/12, 12 ---> nshape = 2, 12
data.shape = tuple(list(2,12) + list(90, 180)) ---> data.shape =
(2,12,90,180)
Therefore the new dataset will have a shape of (2,12,90,180) instead of
(25,90,180) which these two are not holding same number of values, I think.
[1]:https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/utils/misc.py
> Refactoring "reshapeMonthlyData" from rcmes/utils/misc.py
> ----------------------------------------------------------
>
> Key: CLIMATE-349
> URL: https://issues.apache.org/jira/browse/CLIMATE-349
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Components: metrics
> Affects Versions: 0.3-incubating
> Reporter: Maziyar Boustani
> Assignee: Maziyar Boustani
> Fix For: 0.4-incubating
>
>
> Refactoring function "reshapeMonthlyData" from [1] to [2] and providing
> unittest for that.
> [1]:https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/utils/misc.py
> [2]:https://svn.apache.org/repos/asf/incubator/climate/trunk/ocw/utils.py
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
