----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9900/#review18251 -----------------------------------------------------------
A few things to fix before applying the patch: 1. There are trailing whitespaces in the patch, I removed those but the patch is corrupt. So please resubmit. 2. The if-elif-else block is not formatted, can you please fix it? 3. Minor nitpick : but use less verbose error strings. - Prasanna Santhanam On March 13, 2013, 12:46 p.m., Pradeep Soundararajan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9900/ > ----------------------------------------------------------- > > (Updated March 13, 2013, 12:46 p.m.) > > > Review request for cloudstack, David Nalley, Chip Childers, Hugo Trippaers, > Alex Huang, Wido den Hollander, and Noa Resare. > > > Description > ------- > > BUG-ID: CLOUDSTACK-1252 Summary: Failed to download default template in VMware > > Proposing to modify package.sh script. Package as per OSS or NONOSS arguments. > > Signed-off-by: Pradeep <pradeep.soundarara...@citrix.com> > -------------------------------------------------------------------------------------- > > Now package.sh will act based on the below usage i.e. with or without > arguments: > > ./package.sh -h > > usage: ./package.sh [-p|--pack] [-h|--help] [ARGS] > > The commonly used Arguments are: > oss|OSS To package OSS specific > nonoss|NONOSS To package NONOSS specific > > Examples: ./package.sh -p|--pack oss|OSS > ./package.sh -p|--pack nonoss|NONOSS > ./package.sh (Default OSS) > > --------------------------------------------------------------------------------------- > > > Diffs > ----- > > packaging/centos63/cloud.spec 1b2c9a9633e161081809c3aa25574fdb863d4d0b > packaging/centos63/package.sh 2515ecba11fee3ea8dd5f85884861585392a26cd > > Diff: https://reviews.apache.org/r/9900/diff/ > > > Testing > ------- > > I have tested these changes. They are working well. Please review and submit > it if you are fine. > > In future, we can even change the mvn commands as per our need from > cloud.spec. > > > Thanks, > > Pradeep Soundararajan > >
