-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10122/
-----------------------------------------------------------

(Updated March 26, 2013, 9:02 p.m.)


Review request for cloudstack, akarasulu and edison su.


Changes
-------

Additional changes:

- root filesystem xml for Libvirt has been moved to createVbd()
- added LibvirtConnection.getConnectionByVmName6
- changed relevant calls to getConnection() to use getConnectionByVmName()
- calls to getConnection() for pool/storeage related information is not 
affected by connection url

Testing:

- wiped and rebuilt a clean installation with KVM system vms and LXC container


Description
-------

This is a patch for adding LXC support to Cloudstack.

Please see the following links for more details:

Design doc: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/LXC+Support+in+Cloudstack
Jira ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-922


Diffs (updated)
-----

  agent/conf/agent.properties f7eac67 
  api/src/com/cloud/agent/api/Command.java 9cd6749 
  api/src/com/cloud/agent/api/RebootCommand.java 299e61b 
  api/src/com/cloud/agent/api/StopCommand.java 9ee7ce3 
  api/src/com/cloud/hypervisor/Hypervisor.java 2e0012d 
  api/src/com/cloud/storage/Storage.java fba12b6 
  client/tomcatconf/componentContext.xml.in a98a41f 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/DirectVifDriver.java
 PRE-CREATION 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 8ee3ea4 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtConnection.java
 981d343 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
 b622b6d 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtStorageVolumeDef.java
 d5cd91a 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 
c93aeeb 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMPhysicalDisk.java
 08f51a4 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java
 c2bfad9 
  
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
 d5e6ad6 
  
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java
 b723875 
  scripts/storage/secondary/cloud-install-sys-tmplt 2172b28 
  server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 544a803 
  server/src/com/cloud/hypervisor/LXCGuru.java PRE-CREATION 
  server/src/com/cloud/hypervisor/kvm/discoverer/KvmServerDiscoverer.java 
75e00ad 
  server/src/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java 
PRE-CREATION 
  server/src/com/cloud/hypervisor/kvm/discoverer/LxcServerDiscoverer.java 
PRE-CREATION 
  server/src/com/cloud/network/SshKeysDistriMonitor.java fc7c882 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
6742f7b 
  server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 
46ac7af 
  server/src/com/cloud/template/HypervisorTemplateAdapter.java 1426421 
  server/src/com/cloud/vm/VirtualMachineManagerImpl.java 0aeef0e 
  setup/db/db/schema-410to420.sql eb650cc 
  ui/scripts/system.js c0a5d14 
  ui/scripts/templates.js 040ce4a 
  ui/scripts/zoneWizard.js 5108c5c 

Diff: https://reviews.apache.org/r/10122/diff/


Testing
-------

Performed end-to-end testing for starting an LXC instance:

- Add an LXC cluster
- Add an LXC host
- Register an LXC template
- Spin up an LXC container

Additional testing:

- Verified connectivity with direct network settings
- Used KVM systemvm with LXC cluster


Thanks,

Phong Nguyen

Reply via email to