----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10145/#review18419 -----------------------------------------------------------
Ship it! 0004-CLOUDSTACK-1818-make-DababaseCreator-ready-to-invoke.patch and 0002-CLOUDSTACK-1795-implement-custom-AOP-to-fully-suppor.patch had to be applied via "git apply" for some reason, but they took. I also had to resolve a build issue introduced by a conflicting commit around bare-metal that hit the repo between the time you submitted and the time I applied. However, it's all in the 4.1 branch now. Please ensure that everything makes it back into master! Thanks. - Chip Childers On March 27, 2013, 1:20 p.m., Kelven Yang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10145/ > ----------------------------------------------------------- > > (Updated March 27, 2013, 1:20 p.m.) > > > Review request for cloudstack and Chip Childers. > > > Description > ------- > > This review contains a number of important fixes. > > 1) Custom Spring AOP to fully support legacy CloudStack AOP semantics. > Previous Spring intergration is lacking of a fundamental support for legacy > CloudStack AOP usage, it does not have a 100 percent coverage that caused bug > like CLOUDSTACK 1664, and these bugs are hard to fix due to limitation of > proxy-based Spring AOP implementationo. > > The fix is to patch Spring with a custom AOP implementation, and it will have > 100 percent coverage of old CloudStack AOP usage > > 2) Remove Component auto-scanning > 3) Ensure adapter execution ordering > > Some of the adapter logic requires ordering of execution, removing component > auto-scanning and having execution order to be explicitly configured are > related to be fixed together. > > These patches may look rather large, but I've been very careful and have done > a number of manual test in every step. The patches have been rebased to > latest head. Please merge it as soon as possible > > > This addresses bugs 1276, 1729, 1795, 1818, and CLOUDSTACK. > > > Diffs > ----- > > > Diff: https://reviews.apache.org/r/10145/diff/ > > > Testing > ------- > > Low level changes, manually tested with OSS/non-OSS with VM deployment tests. > > > Thanks, > > Kelven Yang > >
