----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10151/ -----------------------------------------------------------
(Updated March 29, 2013, 5:49 a.m.) Review request for cloudstack and Rohit Yadav. Changes ------- Marking for master since 4.1 is under code freeze Description ------- Change to requester.py to make it give back the actual error that was thrown by the API (the HTTPError bit). The rest is to catch the correct result code and act accordingly on async requests. Initially async requests seemed to work because of the sleep that was introduced before the second call and usually the api would be able to respond within the sleep, the issue was however that if a call would take longer another request would be spawned due to the recursive call that was done on monkeyrequest, and so re-curse on itself, a side effect of this was that it never gave the output of the result, but rather that of the initial response for calls that would take longer. A nice side effect is that the script no longer waits the interval for every call it makes. Diffs ----- tools/cli/cloudmonkey/requester.py 5c4cd1e Diff: https://reviews.apache.org/r/10151/diff/ Testing ------- I have two scripts, the first monkey.sh, which creates a complete zone with basic networking and waits till the systevms have succesfully booted. The other a script called monkey-clean.sh which tears the entire stack down using cloudmonkey. So this includes setting up the zone, physical networking, networking, pod, cluster, hypervisors, primary and secondary storage. Thanks, Funs Kessen
