----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10250/#review18648 -----------------------------------------------------------
Ship it! applied to 4.1 and cherry-picked to master - Chip Childers On April 3, 2013, 1:41 p.m., Alex Huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10250/ > ----------------------------------------------------------- > > (Updated April 3, 2013, 1:41 p.m.) > > > Review request for cloudstack and Chip Childers. > > > Description > ------- > > The bug was because when Rohit rolled back the schema file he rolled it back > to 4.0 schema file - the index file. We no longer add to the index file so > that mistake is understandable but there were left over indexes and > constraints in that file. What I did is moved it directly on to > create-schema.sql. > > Chip, Please add this to 4.1 and I will cherry-pick over to master. > > > This addresses bug CLOUDSTACK-1839. > > > Diffs > ----- > > setup/db/create-schema.sql 7361681 > > Diff: https://reviews.apache.org/r/10250/diff/ > > > Testing > ------- > > I tested manually by checking on the indexes after the db creation is done > but before management server starts up. Unfortunately, there's no actual > diff that tell me the difference QA was looking for so I couldn't match it > exactly to what QA thinks should be in the newly created schema. QA will > need to verify everything they want is there in the new schema now. > > > Thanks, > > Alex Huang > >
