----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10275/ -----------------------------------------------------------
Review request for cloudstack. Description ------- Added 1. display = [default|json|tabularize] has been added in the config to replace tabularize = [true|false] 2. tabularize is deprecated but we will still set it as "false" once the user removes it out of their config to avoid throwing an error. This will be removed in the next major version. 3. display = "default" is added to the [ui] section of the config if it is not present. 4. You can now output JSON formatted text by setting the config display = json 5. You can now filter text in JSON output mode. (i.e. list users account=grudzien filter=account,id,email). Filtered output returns a properly formatted JSON document. Removed 1. Removed the printing of attr keys in read_config(). Deprecated 1. tabularize = [true|false] is now messaged as deprecated. This addresses bug CLOUDSTACK-1875. Diffs ----- tools/cli/cloudmonkey/cloudmonkey.py 94006c9 tools/cli/cloudmonkey/config.py 75605df Diff: https://reviews.apache.org/r/10275/diff/ Testing ------- [ui] color = true prompt = > tabularize = false display = json $ python cloudmonkey.py list networks filter=name tabularize config parameter is deprecated: please switch to display = [default,json,tabularize] { "count": 2, "network": [ { "name": "admin-network" }, { "name": "GuestNetwork82" } ] } $ python cloudmonkey.py list networkofferings filter=name tabularize config parameter is deprecated: please switch to display = [default,json,tabularize] { "count": 8, "networkoffering": [ { "name": "DefaultSharedNetworkOfferingWithSGService" }, { "name": "DefaultSharedNetworkOffering" }, { "name": "DefaultIsolatedNetworkOfferingWithSourceNatService" }, { "name": "DefaultIsolatedNetworkOffering" }, { "name": "DefaultSharedNetscalerEIPandELBNetworkOffering" }, { "name": "DefaultIsolatedNetworkOfferingForVpcNetworks" }, { "name": "DefaultIsolatedNetworkOfferingForVpcNetworksNoLB" }, { "name": "Test Network Offering" } ] } Thanks, Justin Grudzien