On Sat, Apr 06, 2013 at 05:27:11AM +0000, Prasanna Santhanam wrote: > Ah - misunderstood. Like Hugo said, a test that fails on presence of db > connection should solve this. But I hope ppl will turn mysql on (as an > additional step) to run the bvt. Or better yet, I can look into those db > tests and port them as marvin tests. >
Perhaps I'm confused, but having a unit test that fails the build if MySQL is running on the local machine seems like a really bad idea. I think the problem to solve is just that we want to avoid unit tests that require a DB. As long as we all know this, and that we have build jobs that fail on the CI side of things, isn't that enough? Am I confused? > > > > -- > Prasanna., > > ----- Original Message ----- > From: Alex Huang [mailto:alex.hu...@citrix.com] > Sent: Saturday, April 06, 2013 05:21 AM > To: dev@cloudstack.apache.org <dev@cloudstack.apache.org> > Subject: RE: Master broken > > > That will be hard to do since the checkin test requires the DB to be > > present as > > it starts up the server and sets-up the databases. We'd have to turn it off > > for > > the build and turn it back on again for the bvt. Best if we avoid doing - > > DskipTests when building as a general good rule. > > I don't think -DskipTests is the problem. The problem is actually people who > are running the unit tests have db on their laptops so if they have unit > tests that require DB will run on their laptop but fails on Jenkins, which > doesn't have a db. > > --Alex >
