----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10238/ -----------------------------------------------------------
(Updated April 9, 2013, 3 p.m.) Review request for cloudstack and Abhinandan Prateek. Changes ------- Fixed a few corner cases and improved exception handling. Description ------- Cloudstack-701: Support for non contiguous vlan ranges. Diffs (updated) ----- api/src/com/cloud/network/NetworkService.java ab6d7bf api/src/com/cloud/network/PhysicalNetwork.java a2044a6 api/src/org/apache/cloudstack/api/ApiConstants.java c518830 api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 06cf38d server/src/com/cloud/api/ApiResponseHelper.java 64be7f8 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1526fb0 server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4 server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4 server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java ae00bf2 server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51 server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051 test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION Diff: https://reviews.apache.org/r/10238/diff/ Testing ------- Tested on latest master. Thanks, bharat kumar
