This fixes an bug introduced in that commit. I also want to point out that line 669 in ConfigurationServerImpl.java traps exceptions thrown in development mode, hence this bug would not have surfaced when ran in development mode. This 669 line appears to have been committed months ago, removing it now results in not being able to find vms/injectkeys.sh on startup (which seems related to another thread about injectkeys.sh a few days ago).
-Phong On Fri, Apr 12, 2013 at 6:50 PM, Chiradeep Vittal < chiradeep.vit...@citrix.com> wrote: > Does this conflict with > 5cd3608 Remove the chmod solution and replace with an explicit call to > /bin/bash. This way the file will only need read permissions. > > > > On 4/12/13 2:11 PM, "Phong Nguyen" <pngu...@gilt.com> wrote: > > > > >----------------------------------------------------------- > >This is an automatically generated e-mail. To reply, visit: > >https://reviews.apache.org/r/10437/ > >----------------------------------------------------------- > > > >Review request for cloudstack and Hugo Trippaers. > > > > > >Description > >------- > > > >Management server unable to start (from rpm) due to invalid call to > >Script for injectkeys.sh. > > > >2013-04-12 15:02:13,496 WARN [cloud.server.ConfigurationServerImpl] > >(Timer-1:null) Failed to inject generated public key into systemvm iso > >java.io.IOException: Cannot run program "/bin/bash > >/usr/share/cloudstack-common/scripts/vm/systemvm/injectkeys.sh": error=2, > >No such file or directory > > at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029) > > at com.cloud.utils.script.Script.execute(Script.java:183) > > > > > >Diffs > >----- > > > > server/src/com/cloud/server/ConfigurationServerImpl.java 596387f > > > >Diff: https://reviews.apache.org/r/10437/diff/ > > > > > >Testing > >------- > > > >Rebuilt rpm and tested management server startup -- success > > > > > >Thanks, > > > >Phong Nguyen > > > >
