+1 provided we test it thoroughly and get it reviewed as well to ensure that we don't break the master.
Thanks, -Nitin On 16/04/13 11:01 AM, "Rohit Yadav" <[email protected]> wrote: >+1 > >On Tue, Apr 16, 2013 at 10:59 AM, Mice Xia ><[email protected]>wrote: > >> +1 >> >> -----Original Message----- >> From: Sateesh Chodapuneedi [mailto:[email protected]] >> Sent: Tuesday, April 16, 2013 12:16 PM >> To: [email protected] >> Subject: RE: [DISCUSS] Getting rid of premium >> >> > -----Original Message----- >> > From: Kelven Yang [mailto:[email protected]] >> > Sent: 15 April 2013 22:43 >> > To: [email protected] >> > Subject: Re: [DISCUSS] Getting rid of premium >> > >> > >> > >> > On 4/15/13 8:53 AM, "Hugo Trippaers" <[email protected]> >> > wrote: >> > >> > >Heya, >> > > >> > >As we don't have a premium distribution anymore I would like to get >> > >rid of the premium configuration value. At the moment it seems to be >> > >unintentionally used to distinguish between the nonss and oss build >> > >so I think it can go. It will likely only confuse people that are new >> > >to the project and doesn't bring anything usefull so it seems. >> > > >> > >I'm willing to trawl through the code and remove any references to >> > >premium and replace it with another flag where needed (for example a >> > >flag to indicate vmware support is available). >> > > >> > >Any thoughts about this? >> > > >> > >Cheers, >> > > >> > >Hugo >> > >> > +1 >> >> +1 >> >>
