> On April 23, 2013, 8:48 a.m., Nitin Mehta wrote: > > server/src/com/cloud/vm/VirtualMachineManagerImpl.java, line 447 > > <https://reviews.apache.org/r/10725/diff/1/?file=283382#file283382line447> > > > > Would restore vm increment these limits again ? > >
Are you talking about resotreVM or recoverVM? In case of restoreVM, it is resetting the VM by deleting old root volume and allocating duplicate root volume, so we don't have to check for limits here. In case of recoverVM, this API option is available only if the root disk is not yet expunged, so it will not increment primary storage limits. > On April 23, 2013, 8:48 a.m., Nitin Mehta wrote: > > server/src/com/cloud/vm/VirtualMachineManagerImpl.java, line 448 > > <https://reviews.apache.org/r/10725/diff/1/?file=283382#file283382line448> > > > > What about the resource limit for the vm ? where is that getting > > decremented. Are these consistent ? Other resource limits related to VM like vm_instance, cpu, memory etc are getting decremented once the destroyVM API returns the result successfully. CloudStack waits for expunging of VM to decrement the storage limits like Volume, primary storage. - Sanjay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10725/#review19579 ----------------------------------------------------------- On April 23, 2013, 8:42 a.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10725/ > ----------------------------------------------------------- > > (Updated April 23, 2013, 8:42 a.m.) > > > Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min > Chen. > > > Description > ------- > > CLOUDSTACK-2087: Destroying the instance is not decrementing the primary > storage usage [Resource Count table - No of volumes is not got decremented] > > > This addresses bug CLOUDSTACK-2087. > > > Diffs > ----- > > server/src/com/cloud/vm/VirtualMachineManagerImpl.java c1f3f15 > > Diff: https://reviews.apache.org/r/10725/diff/ > > > Testing > ------- > > Tests: > 1. Deploy an instance from a user account. > 2. Check the updated resource count (primary storage and volume). > 3. Destroy the same instance. > 4. Verify the decremented resource count from the account detailView. > > > Thanks, > > Sanjay Tripathi > >
