----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10005/ -----------------------------------------------------------
(Updated April 23, 2013, 10:31 a.m.) Review request for cloudstack, Murali Reddy and Sateesh Chodapuneedi. Changes ------- Unittest added for new utility added in NetUtils. Rebased to latest master. Description ------- In cases where the start ip and end ip of guest vm cidr and network cidr are same, even when the cidrs appear to be different,the reservation procedure should not go through and user should get a message mentioning that. Added extra check for the same with proper alert message. This addresses bug CLOUDSTACK-1647. Diffs (updated) ----- server/src/com/cloud/network/NetworkServiceImpl.java ac2ac45 utils/src/com/cloud/utils/net/NetUtils.java 5988dd5 utils/test/com/cloud/utils/net/NetUtilsTest.java 28bd71f Diff: https://reviews.apache.org/r/10005/diff/ Testing ------- CIDR : 10.0.144.0/20, Network CIDR : null, guestVmCidr : 10.0.151.0/20 => Reservation is not applied. CIDR : 10.0.144.0/21, Network CIDR : 10.0.144.0/20, guestVmCidr : 10.0.151.0/20 => Existing Reservation is not affected. Thanks, Saksham Srivastava
