----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10740/#review19701 -----------------------------------------------------------
Can you resubmit the patch after changing scope_id/scope_name to zone_id, account_id, cluster_id etc . - Abhinandan Prateek On April 23, 2013, 9:29 p.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10740/ > ----------------------------------------------------------- > > (Updated April 23, 2013, 9:29 p.m.) > > > Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Nitin > Mehta. > > > Description > ------- > > CLOUDSTACK-741: Granular Global Parameters > Adding the zone, cluster, account level parameters: > zone: network.throttling.rate, Guest Domain Prefix > cluster: cluster.cpu.allocated.capacity.disablethreshold, > cluster.cpu.allocated.capacity.notificationthreshold, > cluster.memory.allocated.capacity.disablethreshold, > cluster.memory.allocated.capacity.notificationthreshold > account: allow.public.user.templates, remote.access.vpn.client.iprange > > > This addresses bug CLOUDSTACK-741. > > > Diffs > ----- > > api/src/com/cloud/configuration/ConfigurationService.java 6937d0b > api/src/com/cloud/network/NetworkModel.java 4d7d714 > api/src/org/apache/cloudstack/api/ApiConstants.java e774ecc > api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java > 9f34405 > api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java > 074c5a3 > server/src/com/cloud/alert/AlertManagerImpl.java 655ed98 > server/src/com/cloud/api/ApiDBUtils.java c60af27 > server/src/com/cloud/api/ApiDispatcher.java 925d90a > server/src/com/cloud/capacity/dao/CapacityDao.java 0132f69 > server/src/com/cloud/capacity/dao/CapacityDaoImpl.java c3d9817 > server/src/com/cloud/configuration/Config.java dbcbc53 > server/src/com/cloud/configuration/ConfigurationManager.java 738c5ba > server/src/com/cloud/configuration/ConfigurationManagerImpl.java d5e405d > server/src/com/cloud/deploy/FirstFitPlanner.java 1647cf7 > server/src/com/cloud/network/NetworkManagerImpl.java 72ccac0 > server/src/com/cloud/network/NetworkModelImpl.java c5930d9 > server/src/com/cloud/network/vpc/VpcManagerImpl.java 224a680 > server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 673535a > server/src/com/cloud/server/ConfigurationServerImpl.java cd890ce > server/src/com/cloud/storage/dao/StoragePoolDetailsDaoImpl.java a0d5d0e > server/src/com/cloud/template/TemplateAdapterBase.java 1b11425 > server/src/com/cloud/template/TemplateManagerImpl.java c7eaa64 > server/test/com/cloud/network/MockNetworkModelImpl.java 511249f > server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 6cda294 > server/test/com/cloud/vpc/MockNetworkModelImpl.java 9857964 > > server/test/org/apache/cloudstack/affinity/AffinityApiTestConfiguration.java > fb29469 > > server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java > f1163ef > setup/db/db/schema-410to420.sql 10cdbba > test/integration/smoke/test_global_settings.py 12b35d7 > > Diff: https://reviews.apache.org/r/10740/diff/ > > > Testing > ------- > > > Thanks, > > Harikrishna Patnala > >
