----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10766/#review19702 -----------------------------------------------------------
Ship it! Ship It! - Chip Childers On April 25, 2013, 1:28 p.m., Marcus Sorensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10766/ > ----------------------------------------------------------- > > (Updated April 25, 2013, 1:28 p.m.) > > > Review request for cloudstack and Chip Childers. > > > Description > ------- > > the KVM HA runner uses any NFS secondary storage resource available to a host > to store it's HA data. This causes template deletes to fail because it cannot > delete KVMHA, which is a directory that is not empty. So if KVMHA directory > is found, delete it's contents before trying to delete it. > > > This addresses bug CLOUDSTACK-2173. > > > Diffs > ----- > > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/KVMHAMonitor.java > d1470d6 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java > c2bfad9 > > Diff: https://reviews.apache.org/r/10766/diff/ > > > Testing > ------- > > diff revision 2 was tested with a new 4.1 zone deployment. Verified bug was > reproducable with 4.1 HEAD, applied patch, ran through adding two NFS primary > storages, verified KVM heartbeat was working on them, then ran various > secondary storage operations (register template, download volume, take > snapshot) and verified that they worked, and that KVM heartbeat operations > were NOT acting on them. > > > Thanks, > > Marcus Sorensen > >
