----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10791/#review19773 -----------------------------------------------------------
Ship it! [4.1 2aeb460] CLOUDSTACK-2195: Don't return a UserVM object if we fail to stop vm Author: Marcus Sorensen <shadow...@gmail.com> 2 files changed, 9 insertions(+), 2 deletions(-) - Chip Childers On April 26, 2013, 4:51 a.m., Marcus Sorensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10791/ > ----------------------------------------------------------- > > (Updated April 26, 2013, 4:51 a.m.) > > > Review request for cloudstack, Chip Childers and edison su. > > > Description > ------- > > pass back null if we fail to connect to agent or stop the vm, rather than > something that looks like success to the stopVirtualMachine api command. > > > This addresses bug CLOUDSTACK-2195. > > > Diffs > ----- > > server/src/com/cloud/vm/UserVmManagerImpl.java 7bf04ec > server/src/com/cloud/vm/VirtualMachineManagerImpl.java 2c2986f > > Diff: https://reviews.apache.org/r/10791/diff/ > > > Testing > ------- > > Applied to 4.1 branch, attempted to stop VM with KVM agent disconnected, > finally saw it fail. The logs also showed why, which is good: > > 2013-04-25 17:37:09,933 ERROR [cloud.vm.VirtualMachineManagerImpl] > (Job-Executor-1:job-44) Unable to stop vm, agent unavailable: > com.cloud.exception.AgentUnavailableException: Resource [Host:1] is > unreachable: Host 1: Host with specified id is not in the right state: > Disconnected > > Started the KVM agent, and stopping succeeded. > > > Thanks, > > Marcus Sorensen > >
